gnupic: ckuskie@dalsemi.com: Best way to send patches to gputils?
Subject:
ckuskie@dalsemi.com: Best way to send patches to gputils?
From:
Colin Kuskie ####@####.####
Date:
20 Dec 2002 00:56:42 -0000
Message-Id: <20021220004921.GI3750@dalsemi.com>
I got bit several times by putting F addresses into the P arguments of
MOVFP and MOVPF while programming a 17C4X series type PIC. So I
modified directive.c, gperror.[ch] to include a warning if it detects
such happening. The core of it is in directive.c:file_ok, where I did
this:
! void file_ok(unsigned int file, unsigned int PvF)
{
if ((0 > file) || (file > state.maxram) || (state.badram[file])) {
gpwarning(GPW_INVALID_RAM, NULL);
}
+ if ((PvF == 1) && ((file & 0x1f) != file) ) {
+ gpwarning(GPW_INVALID_PREG, NULL);
+ }
Are you, the developers, interested in this as a patch, and if so,
what's the best way to send it (i.e preferred format)?
Thank you for making gpasm and the rest of the gputils, they've been
a great help for my project.
Colin
