gnupic: Re: [gnupic] gpasm: .direct macro doesn't work
Subject:
Re: [gnupic] gpasm: .direct macro doesn't work
From:
David ####@####.####
Date:
6 Oct 2007 03:22:24 +0100
Message-Id: <20071005221936.2dbaf311@DEEPTHOUGHT.BARNET.net>
On Thu, 4 Oct 2007 21:50:02 -0700 (PDT)
"Scott Dattalo" ####@####.#### wrote:
> ...
> But I discovered that the .direct macros now fail.
> ...
>
> David, I know you have made many changes to gpasm recently. Do you
> know what may be happening here?
I think I know exactly what's happening now. Prior to 6/17/07 a
single-character string literal was considered identical to a character
literal. For example "e" meant the same as 'e'. This was a hack for
some fancy coercion in MPLAB and meant that it was impossible to
represent the string literal "e". I made some changes so that this
coercion happened explicitly in the parser or later. The two cases
where I applied the coercion were for 8-bit literal instruction
operands and higher-level expression operands. It looks like directives
like '.direct' were one case that got overlooked. I attached a diff of
the relevant changes so you can see exactly what I'm talking about.
For now you can work around this by changing the "C", "a", and "e"
literals to single-quoted literals ('C', 'a', and 'e'). You could also
apply the diff file attached in reverse and rebuild if you need, but
that's probably even more of a hassle. In terms of a real solution, if
we can figure out exactly which cases still need to be coerced, we can
avoid similar problems. I'm not sure how you feel about the original
fix, but I'd rather not revert permanently since I feel like not being
able to represent single-character string literals is a real flaw.
David Barnett
[Content type text/x-patch not shown. Download]
