nanogui: it seems a bug
Subject:
Re: it seems a bug
From:
"Greg Haerr" ####@####.####
Date:
12 Nov 2000 17:36:12 -0000
Message-Id: <053401c04ccf$369eec60$15320cd0@gregh>
: in microwin/src/drivers/fblin4.c: line 93. it seems we should only do xor to
the right part.
: such as :
: *addr = (*addr & notmask[x1&1]) | ((c << ((1-(x1&1))<<2)) ^ (*addr &
notmask[1-x1&1]) );
: is it right...
Hmm.. It looks like you're correct. This bug is normally
not noticed except when lines are drawn with an odd length.
Also, fblin2.c and fblin1.c have the same problem.
:
: and
:
: we can do some optimization:
: newc = c |( c << 4);
: then we can do most operation ( XOR , SET) byte by byte, only need
: do half bytes operation at the beginning or end.
That's a great idea. I don't have a 4bpp machine here,
can you fix it and provide an optimized version as well?
Regards,
Greg
